Re: VS 2008

From:

Goran <goran.pusic@gmail.com>

Newsgroups:

microsoft.public.vc.mfc

Date:

Sun, 28 Feb 2010 09:39:31 -0800 (PST)

Message-ID:

<9a3cc807-aff4-4baa-9f7c-53032285405c@g28g2000yqh.googlegroups.com>

On Feb 26, 11:44 pm, DanB <a...@some.net> wrote:

Well I finally bought the new 2008 VS. I'm moving carefully over as I
have to keep a 7.1 build current. I'm moving my support first as I don't
have to keep it updated. I started with that hexml project.

When I get to this as a copy constructor:

XMLNODESET::XMLNODESET( XMLNODESET& inSet )
{
*this= inSet;

}

dec:
class HE_XML_EXT_CLASS XMLNODESET
{
private:
std::vector<TiXmlNode*> set;
...

};

The pointer to the vector is copied now where as in 7.1 it would do a
deep copy of the vector.

You are mistaken, "deep" copy was never done for a vector like yours
(I assume that by "deep" you mean copies of TiXmlNode were created on
the heap when copying a vector using it's operator=). If you still
think that was the case, post sample code here so that we can compare.

That said, you might need to look at your XMLNODESET& operator= and
you really should change your input param to const XMLNODESET& (note
"const").

Goran.