On Jun 30, 8:56?pm, "John B. Matthews" <nos...@nospam.invalid> wrote:
In article
<705241e2-649a-45df-b1e3-d8ad69f3e...@t13g2000yqt.googlegroups.com>,
?Ron <bnor...@gmail.com> wrote:
[...]
I think maybe the process finishes, the stream gets closed, my
java program attempts to read the next line of output and gets
the IOException. ?I think the timing has to be just right though,
because given the same command, I sometimes see the exception and
sometimes not. ?I also thought that maybe the process is not
outputing an EOF before exiting as a possible cause, but that
doesn't really explain why, for the same command, I sometimes get
the exception, and sometimes do not.
Looking closer at your initial example, I see that you are creating
a new ProcessBuilder and starting it to yield Process p. Then you
start a new Thread from which you read p's stdout and wait for p to
complete. Instead, shouldn't you do something more like this:
import java.io.BufferedReader;
import java.io.InputStreamReader;
public class PBTest {
? ? public static void main(String[] args) {
? ? ? ? ProcessBuilder pb = new ProcessBuilder("ls", ".");
? ? ? ? pb.redirectErrorStream(true);
? ? ? ? try {
? ? ? ? ? ? Process p = pb.start();
? ? ? ? ? ? String s;
? ? ? ? ? ? // read from the process's combined stdout & stderr
? ? ? ? ? ? BufferedReader stdout = new BufferedReader (
? ? ? ? ? ? ? ? new InputStreamReader(p.getInputStream()));
? ? ? ? ? ? while ((s = stdout.readLine()) != null) {
? ? ? ? ? ? ? ? System.out.println(s);
? ? ? ? ? ? }
? ? ? ? ? ? System.out.println("Exit value: " + p.waitFor());
? ? ? ? ? ? p.getInputStream().close();
? ? ? ? ? ? p.getOutputStream().close();
? ? ? ? ? ? p.getErrorStream().close();
? ? ? ? ?} catch (Exception ex) {
? ? ? ? ? ? ex.printStackTrace(System.out);
? ? ? ? }
? ? }
}
The way I did it is recommended in a number of places, including a
paper on Sun's website, and also Mr. Green's java glossary. Having
dedicated threads to service the standard out, standard error and
standard input lets you do stuff with all three simultaneously, and
you can treat stdout and stderr separately, if desired. The
waitFor() method also gives you the exit value of the process, if
that interests you.
But if you don't need any of that, I don't see why your example
program would not work. But comparing the two, I don't immediately
see a reason why your example and my example would behave differently
with regard to the problem I am seeing.
about a threading issue. I see that ProcessBuilder is not synchronized.
John B. Matthews