Re: (File)OutputStreams and their usage

From:

Leonard Milcin <leonard@milcin.dont-spam.pl>

Newsgroups:

comp.lang.java.programmer

Date:

Fri, 16 May 2008 20:09:44 +0200

Message-ID:

<482dcde7$1@news.home.net.pl>

Tom Anderson wrote:

I'm dubious about the close() in the finally block not being wrapped in
a try-catch; if i get an IO error during loading, i want to see that,
not some subsequent exception that arose when trying to close the file.
I'd wrap it in a try-catch and log or ignore any exceptions.

There's actually a yet slicker way to write this method:

public void load(File file) throws IOException {
    OutputStream os = new FileOutputStream(file) ;
    try {
        load(os) ;
    }
    finally {
        try {
            os.close() ;
        }
        catch (IOException e) {
            // log or ignore
        }
    }
}

Well, to summarize things, we end up with:

public void load(File file) throws IOException {
     OutputStream os = new FileOutputStream(file);
     try {
         load(os);
     } finally {
         os.close();
     }
}

I'll add a question of my own: why are we loading from an *output* stream?

Perhaps we're loading *into* output stream.

Regards,
Leonard

--
Simplicity is the ultimate sophistication.
-- Leonardo da Vinci