Re: My set fails

From:

Lew <lew@lewscanon.com>

Newsgroups:

comp.lang.java.programmer

Date:

Sun, 23 Mar 2008 06:37:48 -0400

Message-ID:

<nLydnUx1-rRgr3vanZ2dnUVZ_judnZ2d@comcast.com>

-Rick- wrote:

   public boolean equals(Object o) {
       if (!(o instanceof SetTest))
           return false;
       SetTest s = (SetTest)o;
       if(s.getS1() == this.getS1() && s.getX1() == this.getX1())
           return true;
       else
           return false;

How come you don't just
return s.getS1() == this.getS1() && s.getX1() == this.getX1();
?

   }

   public static void main(String[] args){
       populate();
       System.out.println("The size of set is: " + set.size());

rossum wrote:

What is set.size()? You have not declared anything called "set" and
you have not defined a method called"size()".

-Rick- wrote:

static protected Set<SetTest> set = new TreeSet<SetTest>();
}

And that is the reason I excoriate placing member declarations at the bottom.

The standard is to place them before method declarations:
<http://java.sun.com/docs/codeconv/html/CodeConventions.doc2.html#1852>

To the OP: You cause confusion when you deviate from the standard or the few
allowable variations (e.g., the opening brace on its own line indented the
same as its control statement).

--
Lew