Re: What's wrong in this transaction?

From:

"vahan" <agavelian@gmail.com>

Newsgroups:

comp.lang.java.programmer

Date:

8 Nov 2006 05:03:07 -0800

Message-ID:

<1162990987.143057.307780@b28g2000cwb.googlegroups.com>

I think it will work:

    public String executeTransaction() throws java.sql.SQLException {
        java.sql.Connection conn = null;
        javax.sql.DataSource dataSource =
Singleton.getInstance().getDataSource();
        conn = dataSource.getConnection();

        Experiment exp = (Experiment) ViewUtils.eval("#{experiment}");

        List results = new ArrayList();
        ResultSet rs = null;
        Statement stmt = null;
        boolean allgood = false;
        if (conn != null) {

            conn.setAutoCommit(false);
            //you can change Transaction Isolation level

//conn.setTransactionIsolation(java.sql.Connection.TRANSACTION_READ_COMMITTED);
            conn.setSavepoint();//set rollback point

            try {
                for (int i = 0; i < exp.getExperiments().size(); i++) {

                    ((java.sql.PreparedStatement)
                     exp.getExperiments().get(i)).executeUpdate();
                    if (i == (exp.getExperiments().size() - 1)) {
                        conn.commit();
                    }

                }
            } catch (Exception e) {
                    conn.rollback();
                    e.printStackTrace();
                }

        } else {
            System.out.println("connessione non disponibile");
        }

        return "submit";
    }
gbattine wrote:

Hi guys,
i've developed a jsf application.
I do lots of prepared statement in a session,what i want is do all in a
transaction. So i've created an object that collects all the prepared
statement of the session.
When the user click a final submit botton transaction has to b
executed.
My problem is that if a sql exception comes where object is executed
rollback isn't called and transaction is partial executed!!!!!!!
Why this?
Can you help me finding error in my simple code?
Thanks very much

This is my method
public String executeTransaction() throws SQLException {
        Connection conn=null;
        DataSource dataSource = Singleton.getInstance().getDataSource();
        conn = dataSource.getConnection();

            Experiment exp = (Experiment) ViewUtils
            .eval("#{experiment}");

            List results=new ArrayList();
            ResultSet rs=null;
            Statement stmt=null;
            boolean allgood=false;
            if (conn != null) {

                conn.setAutoCommit(false);

                for (int i=0;i<exp.getExperiments().size();i++){
                    try{

                    ((java.sql.PreparedStatement)
exp.getExperiments().get(i)).executeUpdate();
      if(i==(exp.getExperiments().size()-1))
      conn.commit();
                    }
                    catch (Exception e) {
                        conn.rollback();
                        e.printStackTrace();
                    }

                }

            }
            else System.out.println("connessione non disponibile");

        return "submit";
    }

please help me