Re: Way to optimize this?

From:

Eric Sosman <esosman@ieee-dot-org.invalid>

Newsgroups:

comp.lang.java.programmer

Date:

Fri, 06 Nov 2009 23:19:39 -0500

Message-ID:

<hd2sgq$nen$1@news.eternal-september.org>

Jim Janney wrote:

laredotornado <laredotornado@zipmail.com> writes:

Hi,

I'm using Java 1.5. My code checker (PMD plug-in, part of Eclipse
Galileo), is complaining about the line "Integer fileCount = null;" in
the following ...

  public Integer getVendorRequestFileDigestCount(final
YouthfulDriverVendor vendor,
                                                 final String
requestFileDigest) {
    Integer fileCount = null;
    final Session session = sessionFactory.openSession();
    try {
      fileCount = (Integer)
        session. createCriteria(AddressRequestFile.class)
        .add(Restrictions.eq("requestFileDigest", requestFileDigest))
        .add(Restrictions.eq("vendor", vendor))
        .add(Restrictions.gt("processingResult", 0))
        .add(Restrictions.isNotNull("processingDate"))
        .setProjection(Projections.rowCount()).uniqueResult();
    } finally {
      session.close();
    }
    return fileCount;
  }

with the complaint, "Found 'DD' -- anomaly for 'fileCount', lines
123-126". Evidently, it doesn't like the fact that the value of the
variable "fileCount" changes. But I don't know how to rewrite this
code block to satisfy the code checker. Do you?

Thanks, - Dave

The complaint is simply that you're initializing a variable to a value
that is never used, just as if you had written

int i = 4;
i = 15;

No, the initial value *is* used, if anything in that
chain of method calls throws an exception.

The minimal fix is to remove the useless initialization for fileCount: replace
Integer fileCount = null;
with
Integer fileCount;

I think that would produce a compile error. (But I've
already embarrassed myself once on a similar point in this
thread, so don't take my word for it ...)

--
Eric Sosman
esosman@ieee-dot-org.invalid