Re: (File)OutputStreams and their usage

From:

Tom Anderson <twic@urchin.earth.li>

Newsgroups:

comp.lang.java.programmer

Date:

Sat, 17 May 2008 12:26:14 +0100

Message-ID:

<Pine.LNX.4.64.0805171224570.27614@urchin.earth.li>

On Fri, 16 May 2008, Leonard Milcin wrote:

Tom Anderson wrote:

I'm dubious about the close() in the finally block not being wrapped in a
try-catch; if i get an IO error during loading, i want to see that, not
some subsequent exception that arose when trying to close the file. I'd
wrap it in a try-catch and log or ignore any exceptions.

There's actually a yet slicker way to write this method:

public void load(File file) throws IOException {
    OutputStream os = new FileOutputStream(file) ;
    try {
        load(os) ;
    }
    finally {
        try {
            os.close() ;
        }
        catch (IOException e) {
            // log or ignore
        }
    }
}

Well, to summarize things, we end up with:

public void load(File file) throws IOException {
   OutputStream os = new FileOutputStream(file);
   try {
       load(os);
   } finally {
       os.close();
   }
}

I don't like the unprotected close() in the finally block. But if you're
happy with it, then yes.

tom

--
I didn't think, "I'm going to change the world." No, I'm just going to
build the best machines I can build that I would want to use in my own
life. -- Woz