Re: String getTagValue(Document doc, String tag)
On Sep 25, 6:39 am, gert <gert.cuyk...@gmail.com> wrote:
I am used to work with javascript, where you can do things like
"v=doc.getElementsByTagName('test')[0].childNodes[0].nodeValue".
I am trying to do the same in java like this but i think l2=(NodeList)
l1.item(t); is not the same as childNodes or is it ?
This is terrible code. I can hardly follow it at all.
protected String getTag(Document doc, String tag)
{
String v = null;
Don't initialize strings to null. Also, if you're building up a
string, you should use a StringBuilder.
NodeList l1,l2 = null;
You would be better off declaring objects where you initialize them.
Node n = null;
Integer t,t_,c,c_ = null;
NONE of these variable names make an sense! Use meaningful names!
l1=doc.getElementsByTagName(tag);
t_=doc.getElementsByTagName(tag).getLength();
for(t=0;t<t_;t++)
{
l2=(NodeList) l1.item(t);
c_=l2.getLength();
for(c=0;c<c_;c++)
{
n=l2.item(c);
v=v+ n.getNodeValue();
}
}
return v;
}
Also, if you're translating the javascript into java, you have added
WAY too much.
What you wrote in javascript:
"v=doc.getElementsByTagName('test')[0].childNodes[0].nodeValue".
what you want in java:
protected String getTag(Document doc, String tagname) {
return
doc.getElementsByTagName(tagname).item(0).getChildNodes().item(0).getNodeValue();
}
There aren't any loops in the js, so why should there be in the java?
Hope this helps.