Re: String Reverse

From:

Lew <lew@lewscanon.com>

Newsgroups:

comp.lang.java.programmer

Date:

Fri, 12 Oct 2007 09:32:47 -0400

Message-ID:

<IeednSum9pLi6pLanZ2dnUVZ_tijnZ2d@comcast.com>

Malinbeg wrote:

String reverse (String in)
throws IOException

To the OP:
This is an example, bear in mind. In Real Life trap and log exceptions at the
point of occurrence, then perform a strategic recovery (possibly to exit the
app?).

{
Reader reader = new StringReader(in);

Note the good use of an interface variable type with a concrete implementation
run-time type. This is a best practice.

Stack<Character> stack = new Stack();

Oops. "new Stack<Character>()".

int ch;

The scope of "ch" is too wide. Put it into a for loop.

    while ((ch = reader.read()) != -1)
    {
        stack.push((char)ch);
    }

    Writer writer = new StringWriter();

This one cannot go into a for loop because the value is needed after the loop.

    while (!stack.isEmpty())
    {
        writer.write(stack.pop());
    }

    String reversed = writer.toString();

    return reversed;
}

There are ways that follow this pattern without using java.io, also.

--
Lew