Re: can u give me this program
Gopi wrote:
my code is like this
[hundreds of lines of code omitted]
this is my code but getting some mistakes
John B. Matthews wrote:
For the particular case of IndexOutOfBoundsException arising in
subclasses of Bank, note that ArrayList indexes start at zero, not one.
<http://download.oracle.com/javase/6/docs/api/java/util/ArrayList.html>
For the general case, do not use TAB characters to indent Usenet posts. Do
use spaces, up to four per indent level.
In the particular case of (TABs removed):
public class Bank {
String AccID;
ArrayList<Bank> national;
ArrayList<Bank> privte;
public String getCustomerID(String bankName,String accType )
{
String randomString;
Random randomGenerator = new Random();
int randomInt=randomGenerator.nextInt();
randomString=Integer.toString(randomInt);
AccID=bankName.concat(randomString);
return AccID;
}
}
You should not allocate a new 'Random' with each call. Make the generator a
member of the class. Otherwise the "random" sequence starts over with each call.
The 'AccID' variable, on the other hand (OTOH), should NOT be a member
variable - as is, it will be shared by every caller to the same object's
'getCustomerID' method. Also, variable names should start with a lower-case
letter, with one exception that does not apply here. Read the coding
conventions document:
<http://www.oracle.com/technetwork/java/codeconv-138413.html>
Finally, learn to spell "you" and "I". Be professional.
--
Lew