Re: BlueJ don't know what i did wrong
On Fri, 22 Feb 2013 06:03:03 -0800 (PST), BlueJguywithoutskill wrote:
Hello,
I wanted to write a program for a table top Game (Heroscape, which should give me random units and if a unit got support units there should be a chance that it give me them too. And that until i got my points.
I'm giving some general advice, as I'm honestly too lazy to reverse
engineer your one-letter variable names - what is c ? b ? d ? g ? p ? l ? I
recommend using your IDEs refactoring to change those to proper variable
names. It causes undue and unneccessary cost when trying to see what the
code does.
I also recommend using English variable and class names. I know you are
German, I am too, but the Java language itself is already in English, and
switching back and forth between two languages every other word again
places undue strain on the readers (and the programmers) brain.
Additionally, it makes it harder to get help.
Speaking of which: de.comp.lang.java exists.
public class ZufaelligeFiguren
{
public String [] Name;
public int [] Punkte;
public int [] Stuetze;
public int [] help;
public int [] zahl;
public int [] nochda;
public ZufaelligeFiguren()
{
Name = new String [159];
Stuetze = new int [159];
Punkte = new int [159];
nochda = new int [159];
help = new int [159];
zahl = new int [159];
Name[0] = "Cyprien Esenwein";
Punkte[0] = 150;
Stuetze[0] = 0;
Ewww. Instead, try something like this:
add a new class file named something like HeroscapeUnit that looks
something like:
public class HeroscapeUnit {
private String name;
private int points;
private int stuetze; // <- what does that word mean ?
private int amount;
private boolean available;
public HeroscapeUnit(String name; int points; int stuetze; int amount;
boolean available) {
this.name = name;
this.points = points;
this.stuetze = stuetze;
this.amount = amount;
this.available = available;
}
public String getName() { return name; }
public void setName(String newName) { name = newName; }
// ...
}
And then in your main program you can do this instead:
public class ZufaelligeFiguren {
private final ArrayList<HeroscapeUnit> units = new
ArrayList<HeroscapeUnit>();
public ZufaelligeFiguren() {
units.add(new HeroscapeUnit("Otonashi", 10, 0, 1, true);
units.add(new HeroscapeUnit("Isamu", 10, 0, 1, true);
units.add(new HeroscapeUnit("Kyntela Gwyn", 20, 8, 0, true);
// ...
I'll help you fix your problem code afte you at the very least made it more
readable. You are also welcome to post your question in German in
de.comp.lang.java which I also read and will reply to if you prefer.
Liebe Gruesse,
Joerg
--
Ich lese meine Emails nicht, replies to Email bleiben also leider
ungelesen.