Re: please explain this simple construct

From:

Robert Klemme <shortcutter@googlemail.com>

Newsgroups:

comp.lang.java.programmer

Date:

Tue, 31 Oct 2006 17:07:26 +0100

Message-ID:

<4qpalvFo6jdnU1@individual.net>

On 31.10.2006 15:43, Jeffrey Schwab wrote:

and IMHO it is far superior in cases like this:

public Foo findIt( String name ) {
  for ( Iterator iter = myFoos.itererator(); iter.hashNext(); ) {
    Foo f = (Foo) iter.next();

    if ( name.equals( f.getName() ) ) {
       return f;
    }
  }

  // alternatively throw an exception
  return null;
}

Using the loop condition to break the loop makes this piece of code
much more complex and probably also less efficient.

Maybe, but I still find it clearer, and easier to debug.

Amazing. It would never occur to me that (below) is clearer or easier
to debug than (above). But obviously people are very different.

    public Integer findIt(Integer n) {
        Iterator<Integer> iter = myInts.iterator();
        Integer i = null;
        boolean found = false;
        while(iter.hasNext() && !found) {
            i = iter.next();
            found = (n == i);
        }

        return found ? i : null;
    }

Cheers

robert