Re: Change decimal color code on the fly
Bob wrote:
There might quite a few "oops"
as this is a work in progress.
import java.awt.Component;
import java.awt.image.BufferedImage;
import javax.imageio.ImageIO;
import java.util.ArrayList;
import java.awt.event.*;
import java.awt.image.*;
import java.io.ObjectOutputStream;
import java.io.IOException;
import java.io.FileOutputStream;
public class BufferedImageSto extends Component {
ArrayList<String> colorpxl = new ArrayList<String>();
Usually the declared type of the variable should be the interface, and always it should
be the widest type that supports the logic of the code. And variable names are supposed
to be spelled in camel case. You really should track best practices and coding conventions.
It's recommended that variable names not be overly abbreviated.
Thus, 'List<String> colorPixel ...'
ArrayList<String> dimensions = new ArrayList<String>();
String alphaStr, redStr, greenStr, blueStr, wStr, hStr, mSet,mSetx;
Are you certain all of these should be instance attributes? Why don't you
declare your members 'private'? (There are good reasons; I'm just wondering
whether yours is one of them.)
public static void main(String[] foo) {
new BufferedImageSto();
}
Is this supposed to be a GUI program?
Don't do logic in a constructor. Constructors are for construction. Period.
What you're doing is bad because you're operating on an incomplete object.
public void printPixelARGB(int pixel) {
int alpha = (pixel >> 24) & 0xff;
alphaStr = Integer.toString(alpha);
int red = (pixel >> 16) & 0xff;
redStr= Integer.toString(red);
if (redStr.length() < 2) {
redStr = "0" + redStr;}
You should follow the coding conventions for braces.
if (redStr.length() < 3) {
redStr = "0" + redStr;}
int green = (pixel >> 8) & 0xff;
greenStr= Integer.toString(green);
if (greenStr.length() < 2) {
greenStr = "0" + greenStr;}
if (greenStr.length() < 3) {
greenStr = "0" + greenStr;}
int blue = (pixel) & 0xff;
blueStr= Integer.toString(blue);
if (blueStr.length() < 2) {
blueStr = "0" + blueStr;}
if (blueStr.length() < 3) {
blueStr = "0" + blueStr;}
mSet = redStr + greenStr + blueStr;
Are you doing int-to-hex conversion? Why don't the standard APIs work for you?
mSetx= "121000000";
Why do you reset this variable to the same value over and over and over and over and over and over?
if (mSet.equals( mSetx)) {
mSet = "";
mSet= Integer.toString (255255255);
Seriously?
System.out.println("revision "+ mSet);
Google "Java logging".
}
//System.out.println(mSet);
And this comment is here because ...?
colorpxl.add(mSet);
mSet = "";
}
private void marchThroughImage(BufferedImage image) {
int w = image.getWidth();
String wStr= Integer.toString(w);
int h = image.getHeight();
String hStr = Integer.toString(h);
dimensions.add(wStr);
dimensions.add(hStr);
System.out.println("width, height: " + w + ", " + h);
for (int i = 0; i < w; i++) {
for (int j = 0; j < h; j++) {
// System.out.println("x,y: " + j + ", " + i);
And this comment is here because ...?
int pixel = image.getRGB(i, j);
printPixelARGB(pixel);
System.out.println("");
}
}
String respName = "ColorPixlData.txt";
System.out.println("File Saved as "+ respName);
System.out.println(respName);
Tell me once, tell me twice, tell me once again.
try {
FileOutputStream fout = new FileOutputStream(respName);
ObjectOutputStream out = new ObjectOutputStream(fout);
out.writeObject(dimensions);
out.writeObject(colorpxl);
out.flush();
out.close();
repaint();
}
catch (IOException e) {e.printStackTrace();
Follow coding conventions.
Don't ignore exceptions.
}
}
public BufferedImageSto() {
try {
// get the BufferedImage, using the ImageIO class
BufferedImage image = ImageIO.read(this.getClass().getResource("MH0x.png"));
This might be work to do in a constructor, but in this case I don't think so.
marchThroughImage(image);
This is NOT work to do in a constructor.
} catch (IOException e) {
System.err.println(e.getMessage());
Don't ignore exceptions.
}
}
}
--
Lew