Re: How to tune up this little piece of code?

From:

Thomas Fritsch <i.dont.like.spam@invalid.com>

Newsgroups:

comp.lang.java.programmer

Date:

Tue, 16 Jan 2007 18:47:51 GMT

Message-ID:

<newscache$qj5zbj$uwb$1@news.ops.de>

www wrote:

I am not very good with code performance. I feel at least something
below should be better:

public class Helper
{
    ...//other helping methods

    private static Date aDate = null;
    private static SimpleDateFormat format = (new
SimpleDateFormat("yyyy-MM-dd
HH:mm:ss")).setTimeZone(TimeZone.getTimeZone("UTC"));

The above 3 lines are syntactically wrong because setTimeZone(...)
returns void, and hence can't be assigned to format.
You probably want:
     private static SimpleDateFormat format;
     static
     {
       // This code is executed once when the class is loaded.
       format = (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"));
       format.setTimeZone(TimeZone.getTimeZone("UTC"));
     }

  public static Date getDate(String str) //now the method is much shorter
  {
      if (timeString != null)
      {
          try
          {
              aDate = format.parse(str);
          }
          catch ... //omitted
      }
      return aDate;
  }
}

Do you think my new code is legal? Is better?

--
Thomas