Re: How to use wait() and notifyAll() in simple container object

From:

"andrewmcdonagh" <andrewmcdonagh@gmail.com>

Newsgroups:

comp.lang.java.programmer

Date:

19 Dec 2006 12:12:44 -0800

Message-ID:

<1166559164.211009.30980@i12g2000cwa.googlegroups.com>

On Dec 17, 7:44 pm, John Ersatznom <j.ers...@nowhere.invalid> wrote:

John Ersatznom wrote:

Lew wrote:

public class Container {

        private boolean value = false; // redundant assignment

        public Container(boolean value) {
                this.value = value;
        }

        public synchronized boolean get() {
                return value;
        }

        public synchronized void set(boolean value) {
                this.value = value;
        }

}

Looks like a mutable, synchronized Boolean. Might want to consider a
class name like SynchronizedBoolean. Might want to rename the
get()/set() methods, either to follow JavaBean conventions or to mimic
similar methods in java.lang.Boolean.

- Lew

Why not

public class Container<Foo> {
    private Foo contents;
    public Container (Foo initialContents) {
        contents = initialContents;
    }
    public synchronized Foo getContents () {
        return contents;
    }
    public synchronized setContents (Foo newContents) {
        contents = newContents;
    }
}

Container<Foo> fooHolder = new Container<Foo>(new Boolean(false));Meh, make that last

Container<Boolean> booleanHolder = new Container<Boolean>(new
Boolean(false));

Its rare that you want to new a Boolean, its better to use the already
existing constant

Container<Boolean> booleanHolder = new Container<Boolean>(
Boolean.FALSE);