Re: Suggestions to make cleaner code
#2pencil <number2pencil@gmail.com> wrote in news:1182784240.034919.238870
@w5g2000hsg.googlegroups.com:
/**
*
* Date usage.
*
**/
import java.io.*;
Code doesn't use any io classes, no need to import them.
import java.util.*;
Sloppy coding to import entire package, especially in the case of java.util,
because there's a class name collision between java.util.Date and
java.sql.Date. Better to explicitly name the classes you want to import.
import java.awt.*;
Code doesn't use any AWT classes, no need to import them.
import java.applet.Applet;
Code doesn't use Applet class, no need to import it.
/**
*
* @author #2pencil (www.akroncdnr.com)
*
**/
public class date_ex {
Class name does not follow Java naming conventions.
public static void main(String[] args) throws IOException {
//public void init() {
Calendar now = Calendar.getInstance();
int day=now.get(Calendar.DAY_OF_WEEK);
int month=now.get(Calendar.MONTH);
int date=now.get(Calendar.DAY_OF_MONTH);
String strday = "";
String strmonth = "";
day=now.get(Calendar.DAY_OF_WEEK);
month=now.get(Calendar.MONTH);
date=now.get(Calendar.DAY_OF_MONTH);
if(day==1)strday="Sunday";
Don't put the conditional on the same line as the condition -- when you're
single-stepping through the code in the debugger, it is very difficult to
tell whether you took the branch or not. Instead, use:
if(day==1)
strday="Sunday";
if(day==2)strday="Monday";
Don't hard-code the day numbers. java.util.Calendar has built-in constants
(public static final fields) for these.
if(day==3)strday="Tuesday";
Instead of doing any of this, why not just pass the date to
java.text.SimpleDateFormat, configured with the appropriate format string?
if(day==4)strday="Wednesday";
Your use of (or your failure to use) horizontal white space renders this code
considerably less legible. I'd suggest
if (day == 4)
strday = "Wednesday";
if(day==5)strday="Thursday";
if(day==6)strday="Friday";
if(day==7)strday="Saturday";
if(month==0)strmonth="January";
if(month==1)strmonth="February";
if(month==2)strmonth="March";
if(month==3)strmonth="April";
if(month==4)strmonth="May";
if(month==5)strmonth="June";
if(month==6)strmonth="July";
if(month==7)strmonth="August";
if(month==8)strmonth="September";
if(month==9)strmonth="October";
if(month==10)strmonth="November";
if(month==11)strmonth="December";
System.out.print("Hello!\n");
System.out.print("Welcome: "+strday+" the "+date+" of "+strmonth
+"!");
}
}
Cheers!
GRB
--
---------------------------------------------------------------------
Greg R. Broderick usenet200705@blackholio.dyndns.org
A. Top posters.
Q. What is the most annoying thing on Usenet?
---------------------------------------------------------------------