Re: Is this the wrong way to use std::list?

From:

Andre Kostur <nntpspam@kostur.net>

Newsgroups:

comp.lang.c++

Date:

Sat, 5 Jan 2008 00:01:09 +0000 (UTC)

Message-ID:

<Xns9A1BA37735945nntpspamkosutrnet@209.135.99.21>

TBass <tbj@automateddesign.com> wrote in news:f4b94cc5-b061-424f-bba0-
2d366f56575f@i29g2000prf.googlegroups.com:

So I have a class:

class Client
{
   unsigned int ClientID;
   ....
};

class MyListenSocket
{
    ...
    AddClient( Client *pClient);
    RemoveClient( unsigned int ID );
    std::list<Client> m_listClients;
};

To add clients to the list, AddClient is called:

MyListenSocket::AddClient( Client *pClient )
{
     m_listClients.push_back( *pClient );
}

Why is this function taking a client by pointer? Why confuse the issue?
have it take the Client by const-reference.

But a client can be erased from anywhere on the list. I wrote this
function:

MyListenSocket::RemoveClient( unsigned int ID )
{
          std::list<Client>::iterator it;
          for( it = m_listClients.begin();
               it != m_listClients.end();
               ++it )
          {
               if ( it->ClientID() == ID )
               {
                    m_listClients.erase( it );
                    break;
               }
          }
}

The problem is that this seems to corrupt the heap in my program. I
know that the iterator is corrupted when I use the erase command, but
why would that corrupt the heap?

Because you've got a problem somewhere else. Check your Client class to
make sure that it is properly copy constructable and assignable.