Re: inconsistencies when compiling

From:

"Alf P. Steinbach" <alfps@start.no>

Newsgroups:

comp.lang.c++

Date:

Fri, 25 Jan 2008 12:01:05 +0100

Message-ID:

<13pjg7t7dfbogc7@corp.supernews.com>

* James Kanze:

On Jan 24, 12:53 pm, "Alf P. Steinbach" <al...@start.no> wrote:

* rory:

I'm having some inconsistencies in my program that I can't seem to
debug. Below is code that makes a copy of a binary file, appends a
unique ID and string to the copy of the binary file and then checks

^^^^^^

[...]

//read contents of input file
ifstream file(argv[1]);

He doubtlessly needs to specify binary mode. (In a larger
application, he' probably want to imbue the "C" locale as well.)

I don't think binary mode is intended, because he treats the file as a
text file, using std::getline.

while(!file.eof())

And as we know, this is NOT the way to read all of a file.

Yes, I commented on that two lines further down in the code, at the
unchecked call to std::getline.

Fixing that call would lead to fixing the loop condition as well.

Cheers,

- Alf

--
A: Because it messes up the order in which people normally read text.
Q: Why is it such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?